New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Management of installed maps #2079
Management of installed maps #2079
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2079 +/- ##
=============================================
+ Coverage 54.44% 54.51% +0.06%
- Complexity 3689 3708 +19
=============================================
Files 570 573 +3
Lines 19770 19840 +70
Branches 1141 1144 +3
=============================================
+ Hits 10764 10815 +51
- Misses 8413 8430 +17
- Partials 593 595 +2
Continue to review full report at Codecov.
|
src/main/java/com/faforever/client/game/CustomGamesController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/game/CustomGamesController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/MapsManagementService.java
Outdated
Show resolved
Hide resolved
"check a map" and "update a map" features will be removed from the PR due to #2114 |
f4bbf53
to
bede740
Compare
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/table/factory/CheckBoxCell.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/vault/VaultEntityController.java
Outdated
Show resolved
Hide resolved
I am also thinking that it might be better to just use a list view with highlighting rather than a table for the display since it is only for deleting maps really. What do others think? |
Hi @Sheikah45 |
60a1d4b
to
0c4847e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a minor change
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/management/MapsManagementController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will see if Brutus or axel have anything to say
125b131
to
cd30d50
Compare
Co-authored-by: Ivan <v23620@gmail.com>
Closes #2026
Closes #1102