Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of installed maps #2079

Conversation

Marc-Spector
Copy link
Collaborator

@Marc-Spector Marc-Spector commented Dec 27, 2020

Closes #2026
Closes #1102

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #2079 (a1d867e) into develop (0b21de7) will increase coverage by 0.06%.
The diff coverage is 70.37%.

@@              Coverage Diff              @@
##             develop    #2079      +/-   ##
=============================================
+ Coverage      54.44%   54.51%   +0.06%     
- Complexity      3689     3708      +19     
=============================================
  Files            570      573       +3     
  Lines          19770    19840      +70     
  Branches        1141     1144       +3     
=============================================
+ Hits           10764    10815      +51     
- Misses          8413     8430      +17     
- Partials         593      595       +2     
Impacted Files Coverage Δ Complexity Δ
...ever/client/replay/LocalReplayVaultController.java 54.34% <0.00%> (-1.21%) 7.00 <0.00> (ø)
...ver/client/replay/OnlineReplayVaultController.java 82.47% <0.00%> (-0.86%) 27.00 <0.00> (ø)
...ain/java/com/faforever/client/theme/UiService.java 45.07% <0.00%> (-0.43%) 24.00 <0.00> (ø)
...a/com/faforever/client/map/MapVaultController.java 58.76% <33.33%> (-1.68%) 19.00 <0.00> (ø)
...a/com/faforever/client/mod/ModVaultController.java 54.05% <33.33%> (ø) 11.00 <0.00> (ø)
...lient/map/management/MapsManagementController.java 75.75% <75.75%> (ø) 8.00 <8.00> (?)
...com/faforever/client/map/management/MapFilter.java 80.00% <80.00%> (ø) 1.00 <1.00> (?)
...ent/map/management/RemovableMapCellController.java 89.47% <89.47%> (ø) 8.00 <8.00> (?)
...main/java/com/faforever/client/map/MapService.java 68.37% <100.00%> (+0.12%) 57.00 <2.00> (+2.00)
...ava/com/faforever/client/map/UninstallMapTask.java 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b21de7...cd30d50. Read the comment docs.

@Marc-Spector
Copy link
Collaborator Author

"check a map" and "update a map" features will be removed from the PR due to #2114
I will do it when I have free time.

@Marc-Spector Marc-Spector changed the title (Not finished) Management of installed maps (check, update, delete) (Not finished) Management of installed maps Jan 14, 2021
@Marc-Spector Marc-Spector force-pushed the feature/2026-management-installed-maps branch from f4bbf53 to bede740 Compare January 16, 2021 00:00
@Marc-Spector Marc-Spector changed the title (Not finished) Management of installed maps Management of installed maps Jan 16, 2021
@Marc-Spector Marc-Spector marked this pull request as draft January 16, 2021 00:01
@Marc-Spector Marc-Spector marked this pull request as ready for review January 19, 2021 08:56
@Sheikah45
Copy link
Member

I am also thinking that it might be better to just use a list view with highlighting rather than a table for the display since it is only for deleting maps really. What do others think?

@Marc-Spector Marc-Spector reopened this Feb 6, 2021
@Marc-Spector
Copy link
Collaborator Author

Hi @Sheikah45
I agree with you. Now do not need to use the table view. I will redo the table to the list.

@Marc-Spector Marc-Spector force-pushed the feature/2026-management-installed-maps branch from 60a1d4b to 0c4847e Compare February 18, 2021 21:41
@Marc-Spector
Copy link
Collaborator Author

UI elements
image

Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a minor change

Sheikah45
Sheikah45 previously approved these changes Feb 20, 2021
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will see if Brutus or axel have anything to say

@Sheikah45 Sheikah45 merged commit 22b0a81 into FAForever:develop Feb 21, 2021
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Co-authored-by: Ivan <v23620@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants