Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing slash #2095

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Add missing slash #2095

merged 1 commit into from
Jan 4, 2021

Conversation

1-alex98
Copy link
Member

@1-alex98 1-alex98 commented Jan 4, 2021

Fixes #2094

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #2095 (b8702a4) into develop (98db90d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2095      +/-   ##
=============================================
- Coverage      50.18%   50.17%   -0.02%     
  Complexity      3261     3261              
=============================================
  Files            557      557              
  Lines          19141    19141              
  Branches        1106     1106              
=============================================
- Hits            9606     9604       -2     
- Misses          8992     8994       +2     
  Partials         543      543              
Impacted Files Coverage Δ Complexity Δ
...a/com/faforever/client/api/FafApiAccessorImpl.java 41.96% <0.00%> (ø) 34.00 <0.00> (ø)
...main/java/com/faforever/client/map/MapService.java 52.78% <0.00%> (-0.86%) 28.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98db90d...86f8243. Read the comment docs.

@1-alex98
Copy link
Member Author

1-alex98 commented Jan 4, 2021

u merge that. No idea how to read codecov report

@Sheikah45 Sheikah45 merged commit 1baf31a into develop Jan 4, 2021
@Sheikah45 Sheikah45 deleted the bugfix/#2094-missing-slash branch January 12, 2021 01:24
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TMM changes make querying replays fail because of a missing slash
2 participants