Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse sorting #2117

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Fix reverse sorting #2117

merged 1 commit into from
Jan 16, 2021

Conversation

Sheikah45
Copy link
Member

Fixes #2116

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #2117 (16c3363) into develop (51a3f02) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2117      +/-   ##
=============================================
- Coverage      52.64%   52.56%   -0.09%     
+ Complexity      3486     3478       -8     
=============================================
  Files            555      555              
  Lines          19372    19371       -1     
  Branches        1134     1134              
=============================================
- Hits           10199    10182      -17     
- Misses          8626     8642      +16     
  Partials         547      547              
Impacted Files Coverage Δ Complexity Δ
...forever/client/preferences/PreferencesService.java 48.81% <0.00%> (+0.23%) 29.00 <0.00> (ø)
...faforever/client/remote/JsonMessageSerializer.java 75.00% <0.00%> (-15.63%) 7.00% <0.00%> (-1.00%)
.../faforever/client/remote/domain/ClientMessage.java 40.00% <0.00%> (-10.00%) 2.00% <0.00%> (-1.00%)
...forever/client/remote/domain/FafServerMessage.java 63.63% <0.00%> (-9.10%) 3.00% <0.00%> (-1.00%)
...rever/client/remote/domain/LoginClientMessage.java 91.30% <0.00%> (-4.35%) 10.00% <0.00%> (-1.00%)
...rever/client/patch/GameBinariesUpdateTaskImpl.java 45.61% <0.00%> (-1.76%) 8.00% <0.00%> (-1.00%)
...forever/client/chat/AbstractChatTabController.java 78.12% <0.00%> (-1.57%) 67.00% <0.00%> (-3.00%)
...java/com/faforever/client/main/MainController.java 61.53% <0.00%> (-0.93%) 39.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a3f02...16c3363. Read the comment docs.

@Sheikah45 Sheikah45 merged commit c21825c into develop Jan 16, 2021
@Sheikah45 Sheikah45 deleted the bugfix/#2116-fix-reverse branch February 27, 2021 16:41
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sorted(Collections.reverseOrder()) doesn't work like this
2 participants