Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify with nickserv #2171

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Identify with nickserv #2171

merged 3 commits into from
Mar 4, 2021

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #2171 (431929d) into develop (587ffb1) will increase coverage by 0.33%.
The diff coverage is 45.45%.

@@              Coverage Diff              @@
##             develop    #2171      +/-   ##
=============================================
+ Coverage      54.50%   54.83%   +0.33%     
- Complexity      3706     3730      +24     
=============================================
  Files            573      573              
  Lines          19842    19878      +36     
  Branches        1144     1148       +4     
=============================================
+ Hits           10814    10901      +87     
+ Misses          8433     8381      -52     
- Partials         595      596       +1     
Impacted Files Coverage Δ Complexity Δ
...a/com/faforever/client/chat/KittehChatService.java 73.88% <45.45%> (-1.41%) 61.00 <0.00> (ø)
...faforever/client/remote/JsonMessageSerializer.java 75.00% <0.00%> (-15.63%) 7.00% <0.00%> (-1.00%)
.../faforever/client/remote/domain/ClientMessage.java 40.00% <0.00%> (-10.00%) 2.00% <0.00%> (-1.00%)
src/main/java/com/faforever/client/i18n/I18n.java 73.07% <0.00%> (-9.15%) 15.00% <0.00%> (ø%)
...forever/client/remote/domain/FafServerMessage.java 63.63% <0.00%> (-9.10%) 3.00% <0.00%> (-1.00%)
...rever/client/remote/domain/LoginClientMessage.java 91.30% <0.00%> (-4.35%) 10.00% <0.00%> (-1.00%)
.../main/java/com/faforever/client/fx/JavaFxUtil.java 75.41% <0.00%> (-0.59%) 43.00% <0.00%> (ø%)
.../com/faforever/client/leaderboard/Leaderboard.java 55.10% <0.00%> (+2.04%) 13.00% <0.00%> (+1.00%)
...om/faforever/client/game/GamesTableController.java 74.78% <0.00%> (+3.36%) 47.00% <0.00%> (+5.00%)
src/main/java/com/faforever/client/game/Game.java 87.28% <0.00%> (+4.23%) 57.00% <0.00%> (+2.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587ffb1...431929d. Read the comment docs.

Brutus5000
Brutus5000 previously approved these changes Mar 2, 2021
@Sheikah45 Sheikah45 linked an issue Mar 4, 2021 that may be closed by this pull request
@Sheikah45 Sheikah45 merged commit 976dc3a into develop Mar 4, 2021
@Sheikah45 Sheikah45 deleted the bugfix/irc-identify branch October 9, 2021 13:59
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identify with irc
2 participants