Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client based dtos and use java-commons-dtos #2211

Merged
merged 5 commits into from
Apr 24, 2021

Conversation

Sheikah45
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2211 (6781f22) into develop (f845162) will increase coverage by 0.88%.
The diff coverage is 47.36%.

@@              Coverage Diff              @@
##             develop    #2211      +/-   ##
=============================================
+ Coverage      55.07%   55.95%   +0.88%     
+ Complexity      3751     3697      -54     
=============================================
  Files            576      517      -59     
  Lines          20070    19564     -506     
  Branches        1167     1165       -2     
=============================================
- Hits           11053    10948     -105     
+ Misses          8408     8014     -394     
+ Partials         609      602       -7     
Impacted Files Coverage Δ Complexity Δ
...client/achievements/AchievementItemController.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...orever/client/achievements/AchievementService.java 90.00% <ø> (ø) 9.00 <0.00> (ø)
...ient/achievements/AchievementUnlockedNotifier.java 85.00% <ø> (ø) 6.00 <0.00> (ø)
.../com/faforever/client/api/JsonApiErrorHandler.java 30.00% <ø> (ø) 1.00 <0.00> (ø)
...a/com/faforever/client/api/MockFafApiAccessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ver/client/chat/ChatUserContextMenuController.java 66.48% <ø> (ø) 36.00 <0.00> (ø)
...forever/client/chat/PrivateUserInfoController.java 93.97% <ø> (ø) 22.00 <0.00> (ø)
...aforever/client/chat/UserInfoWindowController.java 75.64% <ø> (ø) 55.00 <0.00> (ø)
src/main/java/com/faforever/client/clan/Clan.java 50.00% <ø> (ø) 12.00 <0.00> (ø)
...java/com/faforever/client/coop/CoopController.java 60.36% <ø> (ø) 17.00 <0.00> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f845162...6781f22. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 49f764d into develop Apr 24, 2021
@Brutus5000 Brutus5000 deleted the maitenance/use-commons-dtos branch May 29, 2021 18:03
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to dto provided in faf commons instead of having special ones
1 participant