Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to open log file on crash #2541

Merged
merged 2 commits into from
Jan 23, 2022

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #2541 (09aa6e7) into develop (496d865) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@              Coverage Diff              @@
##             develop    #2541      +/-   ##
=============================================
+ Coverage      63.86%   63.87%   +0.01%     
- Complexity      4441     4442       +1     
=============================================
  Files            482      482              
  Lines          19350    19353       +3     
  Branches        1116     1116              
=============================================
+ Hits           12357    12361       +4     
+ Misses          6373     6372       -1     
  Partials         620      620              
Impacted Files Coverage Δ
.../notification/ImmediateNotificationController.java 61.90% <66.66%> (ø)
...in/java/com/faforever/client/game/GameService.java 61.12% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496d865...09aa6e7. Read the comment docs.

@Sheikah45
Copy link
Member Author

Closes #2537

@Sheikah45 Sheikah45 linked an issue Jan 23, 2022 that may be closed by this pull request
@Sheikah45 Sheikah45 merged commit fe5f0ee into develop Jan 23, 2022
@Sheikah45 Sheikah45 deleted the feature/open-log-button-after-crash branch January 23, 2022 15:30
fultonm pushed a commit to fultonm/downlords-faf-client that referenced this pull request Jan 23, 2022
fultonm pushed a commit to fultonm/downlords-faf-client that referenced this pull request Jan 23, 2022
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy path of log to clipboard
1 participant