New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix showing empty rating at some points in time in rating chart #2551
Conversation
in rating chart
Codecov Report
@@ Coverage Diff @@
## develop #2551 +/- ##
=============================================
+ Coverage 64.02% 64.04% +0.02%
- Complexity 4508 4510 +2
=============================================
Files 497 497
Lines 19381 19381
Branches 1115 1115
=============================================
+ Hits 12408 12413 +5
+ Misses 6349 6344 -5
Partials 624 624
Continue to review full report at Codecov.
|
The only X point that will not display the rating is 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment about changing date
I have not changed the code associated with the date. In the picture that you showed, I don't see any deviations. Everything is displayed correctly. |
I checked the chart of the other 5 players. It's all right. |
I will double check but in the picture it shows the same date with different rating values. It might have been an overlap but I thought it wasn't. But will check again. |
This is the expected behavior. This means that the player played several games that day. Please look at the chart for the last month (not all the time) for any player. |
@Sheikah45 Could you review the PR? |
Yes I wanted to do another indepth check to make sure the data points don't change but haven't gotten around to it yet |
…rever#2551) Co-authored-by: Ivan <v23620@gmail.com>
Closes #2548