Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing empty rating at some points in time in rating chart #2551

Merged
merged 1 commit into from Apr 3, 2022

Conversation

Marc-Spector
Copy link
Collaborator

Closes #2548

@Marc-Spector Marc-Spector changed the title Fix showing empty rating some points in time in rating chart Fix showing empty rating at some points in time in rating chart Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #2551 (3756ab4) into develop (fe13e21) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2551      +/-   ##
=============================================
+ Coverage      64.02%   64.04%   +0.02%     
- Complexity      4508     4510       +2     
=============================================
  Files            497      497              
  Lines          19381    19381              
  Branches        1115     1115              
=============================================
+ Hits           12408    12413       +5     
+ Misses          6349     6344       -5     
  Partials         624      624              
Impacted Files Coverage Δ
...com/faforever/client/player/PlayerRatingChart.java 84.84% <0.00%> (ø)
...main/java/com/faforever/client/map/MapService.java 76.58% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe13e21...3756ab4. Read the comment docs.

@Marc-Spector
Copy link
Collaborator Author

The only X point that will not display the rating is 0.

@Sheikah45
Copy link
Member

This as implemented changes the date that the points on the graph are associated with which is not desirable.

Screenshot 2022-01-30 080023
Screenshot 2022-01-30 075948

Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment about changing date

@Marc-Spector
Copy link
Collaborator Author

I have not changed the code associated with the date. In the picture that you showed, I don't see any deviations. Everything is displayed correctly.

@Marc-Spector
Copy link
Collaborator Author

I checked the chart of the other 5 players. It's all right.

@Sheikah45
Copy link
Member

I will double check but in the picture it shows the same date with different rating values. It might have been an overlap but I thought it wasn't. But will check again.

@Marc-Spector
Copy link
Collaborator Author

This is the expected behavior. This means that the player played several games that day. Please look at the chart for the last month (not all the time) for any player.

@Marc-Spector
Copy link
Collaborator Author

@Sheikah45 Could you review the PR?

@Sheikah45
Copy link
Member

Yes I wanted to do another indepth check to make sure the data points don't change but haven't gotten around to it yet

@Sheikah45 Sheikah45 merged commit 71b98ba into develop Apr 3, 2022
@Sheikah45 Sheikah45 deleted the bugfix/show-rating branch April 3, 2022 21:45
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The rating is not displayed at some points in time in rating chart
3 participants