Redesign context menu

[Marc-Spector]

Closes #2594

Final View

[codecov]

Codecov Report

Merging #2596 (9735fff) into develop (e19777b) will increase coverage by 0.05%.
The diff coverage is 97.05%.

❗ Current head 9735fff differs from pull request most recent head 954f16d. Consider uploading reports for the commit 954f16d to get more accurate results

@@              Coverage Diff              @@
##             develop    #2596      +/-   ##
=============================================
+ Coverage      65.19%   65.25%   +0.05%     
- Complexity      4797     4819      +22     
=============================================
  Files            519      520       +1     
  Lines          19898    19931      +33     
  Branches        1143     1144       +1     
=============================================
+ Hits           12973    13005      +32     
  Misses          6291     6291              
- Partials         634      635       +1     

Impacted Files	Coverage Δ
...nt/fx/contextmenu/ChangeUsernameColorMenuItem.java	90.90% <90.90%> (ø)
.../faforever/client/chat/ChatUserItemController.java	93.12% <100.00%> (ø)
...orever/client/fx/contextmenu/AbstractMenuItem.java	100.00% <100.00%> (ø)
...t/fx/contextmenu/CancelActionNotifyMeMenuItem.java	90.90% <100.00%> (+0.90%)	⬆️
...menu/CancelActionRunReplayImmediatelyMenuItem.java	90.90% <100.00%> (+0.90%)	⬆️
...rever/client/fx/contextmenu/CopyLabelMenuItem.java	100.00% <100.00%> (ø)
...er/client/fx/contextmenu/CopyUsernameMenuItem.java	100.00% <100.00%> (ø)
.../client/fx/contextmenu/EditPlayerNoteMenuItem.java	100.00% <100.00%> (ø)
...orever/client/fx/contextmenu/NotifyMeMenuItem.java	90.90% <100.00%> (+0.90%)	⬆️
...er/client/fx/contextmenu/ReportPlayerMenuItem.java	100.00% <100.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19777b...954f16d. Read the comment docs.

[BlackYps]

Nice Work! I think an exclamation mark would fit better as a report symbol. Right now it looks more like a conversation option

[Marc-Spector]

The icons of the items are updated. See the first message.

[BlackYps]

Isn't that an "i" instead of an "!"?

[Sheikah45]

The only thing I am not sure about from a UX experience is the now two clicks required to change color and inability to see the color in the menu, although I could be convinced it is worth it

[Marc-Spector]

inability to see the color in the menu

Are you joking? 😏 It is impossible not to see the color in the menu.

I misunderstood you. I don't think this is the commonly used feature. This is my opinion.

[Marc-Spector]

Isn't that an "i" instead of an "!"?

Oops... My mistake, I will fix it

[Sheikah45]

Ah I just realized this is introducing a new icon source. Is there any way we could use icons from our current source and method of using the svg paths? The icon svgs are in src/icomoon and the icons are from https://icomoon.io so we could add icons to that set if needed. You can import the json file to see the available ones.

[Marc-Spector]

https://github.com/FAForever/downlords-faf-client/wiki/Adding-Icons
Maybe just add icons to icons.css and use them?

[Sheikah45]

FAForever/downlords-faf-client/wiki/Adding-Icons Maybe just add icons to icons.css and use them?

That would work as well. Just want the way we set and store icons to be uniform

[Marc-Spector]

I will continue to work with the PR when #2591 will be merged

[Sheikah45]

@Marc-Spector did you plan on continuing this?

[Marc-Spector]

Of course. When I have free time and desire.
There are problems with icons. They look bad and scale poorly when used through style classes.

[Marc-Spector]

This problem would have been solved if we knew how to assign the size of the viewBox in css.

[Marc-Spector]

All icons taken from icomoon.
Note that not every menu item contains an icon, because the icons are poorly scaled. Maybe in the future we will find better icons and add them.

[Marc-Spector]

@Sheikah45 The PR is ready (finished)

[Marc-Spector]

I reverted readme.md file. I don't know why it is displayed in the Files changed tab