Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map name search case-insensitive #2840

Merged
merged 2 commits into from Nov 12, 2022
Merged

Make map name search case-insensitive #2840

merged 2 commits into from Nov 12, 2022

Conversation

Marc-Spector
Copy link
Collaborator

Closes #2839

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #2840 (d79d765) into develop (14fb8d9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2840      +/-   ##
=============================================
+ Coverage      65.63%   65.66%   +0.02%     
- Complexity      5067     5071       +4     
=============================================
  Files            550      550              
  Lines          20631    20635       +4     
  Branches        1158     1159       +1     
=============================================
+ Hits           13542    13549       +7     
+ Misses          6416     6413       -3     
  Partials         673      673              
Impacted Files Coverage Δ
...om/faforever/client/game/CreateGameController.java 71.95% <100.00%> (+0.72%) ⬆️
...main/java/com/faforever/client/map/MapService.java 72.48% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14fb8d9...d79d765. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 12d922a into develop Nov 12, 2022
@Sheikah45 Sheikah45 deleted the bugfix/search branch November 12, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map searchbar in 'create game' only shows case-sensitive matches
3 participants