Resolve #2855 and #2856

[Marc-Spector]

Closes #2855
Closes #2856

[codecov]

Codecov Report

Merging #2854 (e7bd031) into develop (46507ac) will decrease coverage by 0.01%.
The diff coverage is 53.33%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2854      +/-   ##
=============================================
- Coverage      65.43%   65.41%   -0.02%     
  Complexity      5095     5095              
=============================================
  Files            553      553              
  Lines          20794    20795       +1     
  Branches        1167     1168       +1     
=============================================
- Hits           13606    13604       -2     
- Misses          6505     6508       +3     
  Partials         683      683              

Impacted Files	Coverage Δ
...in/java/com/faforever/client/chat/ChatChannel.java	87.50% <ø> (ø)
.../java/com/faforever/client/fx/PlatformService.java	4.13% <0.00%> (-0.03%)	⬇️
...m/faforever/client/game/CustomGamesController.java	63.11% <ø> (-0.60%)	⬇️
...om/faforever/client/chat/ChannelTabController.java	87.84% <42.85%> (-1.49%)	⬇️
...om/faforever/client/game/GameDetailController.java	84.76% <60.00%> (ø)
...om/faforever/client/game/GamesTableController.java	69.67% <100.00%> (+0.56%)	⬆️
...va/com/faforever/client/login/LoginController.java	88.44% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46507ac...e7bd031. Read the comment docs.

[Marc-Spector]

Fixed error messages when updating the topic if try to reconnect the chat

java.lang.IllegalArgumentException: Chat user 'DaphnewenSiwaona' is unknown for channel '#russian'
	at com.faforever.client.chat.KittehChatService.lambda$getOrCreateChatUser$9(KittehChatService.java:203)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at com.faforever.client.chat.KittehChatService.getOrCreateChatUser(KittehChatService.java:203)
	at com.faforever.client.chat.ChannelTabController.getMessageCssClass(ChannelTabController.java:302)
	at com.faforever.client.chat.AbstractChatTabController.renderHtml(AbstractChatTabController.java:627)
	at com.faforever.client.chat.AbstractChatTabController.appendChatMessageSection(AbstractChatTabController.java:577)
	at com.faforever.client.chat.AbstractChatTabController.addMessage(AbstractChatTabController.java:539)
	at com.faforever.client.chat.AbstractChatTabController.lambda$onChatMessage$22(AbstractChatTabController.java:507)
	at com.faforever.client.fx.JavaFxUtil.runLater(JavaFxUtil.java:484)
	at com.faforever.client.chat.AbstractChatTabController.onChatMessage(AbstractChatTabController.java:506)
	at com.faforever.client.chat.ChannelTabController.updateChannelTopic(ChannelTabController.java:218)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
	at java.base/java.lang.Thread.run(Thread.java:833)

java.lang.IllegalArgumentException: Chat user 'Tex' is unknown for channel '#aeolus'
	at com.faforever.client.chat.KittehChatService.lambda$getOrCreateChatUser$9(KittehChatService.java:203)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at com.faforever.client.chat.KittehChatService.getOrCreateChatUser(KittehChatService.java:203)
	at com.faforever.client.chat.ChannelTabController.getMessageCssClass(ChannelTabController.java:302)
	at com.faforever.client.chat.AbstractChatTabController.renderHtml(AbstractChatTabController.java:627)
	at com.faforever.client.chat.AbstractChatTabController.appendChatMessageSection(AbstractChatTabController.java:577)
	at com.faforever.client.chat.AbstractChatTabController.addMessage(AbstractChatTabController.java:539)
	at com.faforever.client.chat.AbstractChatTabController.lambda$onChatMessage$22(AbstractChatTabController.java:507)
	at com.faforever.client.fx.JavaFxUtil.runLater(JavaFxUtil.java:484)
	at com.faforever.client.chat.AbstractChatTabController.onChatMessage(AbstractChatTabController.java:506)
	at com.faforever.client.chat.ChannelTabController.updateChannelTopic(ChannelTabController.java:218)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
	at java.base/java.lang.Thread.run(Thread.java:833)

[Sheikah45]

Can I get a more descriptive title?

[Marc-Spector]

I cannot think of a more descriptive title. Should I split the PR into several parts?

[Sheikah45]

No I guess I can just come up with something when I merge it

[Sheikah45]

Can you fix the conflicts?

[Marc-Spector]

Rebased and resolved the conflicts

[Marc-Spector]

I did not know it was possible to use such the title. 😅