Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodeTableCell fully reusable #2936

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #2936 (4d741ce) into develop (1c672a6) will increase coverage by 0.05%.
The diff coverage is 72.88%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2936      +/-   ##
=============================================
+ Coverage      64.51%   64.57%   +0.05%     
- Complexity      4898     4900       +2     
=============================================
  Files            557      557              
  Lines          20242    20240       -2     
  Branches        1080     1081       +1     
=============================================
+ Hits           13059    13069      +10     
+ Misses          6565     6554      -11     
+ Partials         618      617       -1     
Impacted Files Coverage Δ
...orever/client/filter/FilterCheckboxController.java 100.00% <ø> (ø)
...r/client/filter/FilterMultiCheckboxController.java 94.44% <ø> (ø)
...rever/client/filter/FilterTextFieldController.java 88.88% <ø> (ø)
...ver/client/filter/MutableListFilterController.java 92.59% <ø> (ø)
...ver/client/filter/RangeSliderFilterController.java 78.57% <ø> (ø)
.../filter/RangeSliderWithChoiceFilterController.java 91.17% <ø> (ø)
...a/com/faforever/client/fx/ControllerTableCell.java 0.00% <0.00%> (ø)
...java/com/faforever/client/coop/CoopController.java 52.71% <25.00%> (+0.40%) ⬆️
...in/java/com/faforever/client/game/GameService.java 64.33% <96.15%> (+0.38%) ⬆️
...er/client/filter/AbstractFilterNodeController.java 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ffe32...4d741ce. Read the comment docs.

@Sheikah45 Sheikah45 merged commit f11d601 into develop Mar 7, 2023
@Sheikah45 Sheikah45 deleted the bugfix/watch-controller-memory-leak branch March 7, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant