Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move message handling to ChatChannel and out of ChatController #2961

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #2961 (0183164) into develop (1ac7748) will increase coverage by 0.00%.
The diff coverage is 65.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2961   +/-   ##
==========================================
  Coverage      64.70%   64.71%           
+ Complexity      4898     4880   -18     
==========================================
  Files            556      554    -2     
  Lines          20261    20217   -44     
  Branches        1084     1081    -3     
==========================================
- Hits           13110    13083   -27     
+ Misses          6520     6503   -17     
  Partials         631      631           
Impacted Files Coverage Δ
.../java/com/faforever/client/fx/BrowserCallback.java 14.28% <0.00%> (ø)
...forever/client/chat/MatchmakingChatController.java 62.79% <40.00%> (-10.13%) ⬇️
...aforever/client/chat/PrivateChatTabController.java 74.19% <55.55%> (-1.22%) ⬇️
...java/com/faforever/client/chat/ChatController.java 57.95% <55.76%> (-1.04%) ⬇️
...a/com/faforever/client/chat/KittehChatService.java 72.58% <66.66%> (-1.14%) ⬇️
...in/java/com/faforever/client/chat/ChatChannel.java 80.95% <69.23%> (+0.18%) ⬆️
...forever/client/chat/AbstractChatTabController.java 74.40% <80.64%> (-0.52%) ⬇️
...om/faforever/client/chat/ChannelTabController.java 88.46% <92.85%> (+1.15%) ⬆️
...in/java/com/faforever/client/chat/ChatMessage.java 100.00% <100.00%> (ø)
...ent/teammatchmaking/TeamMatchmakingController.java 95.05% <100.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac7748...0183164. Read the comment docs.

@Sheikah45 Sheikah45 enabled auto-merge (squash) April 22, 2023 14:43
@Sheikah45 Sheikah45 merged commit b86f5c8 into develop Apr 22, 2023
5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/chat-messages branch April 22, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant