Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recreate games container every switch #2962

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

Sheikah45
Copy link
Member

Closes #2954

@Sheikah45 Sheikah45 enabled auto-merge (squash) April 22, 2023 15:26
@Sheikah45 Sheikah45 force-pushed the bugfix/games-controller-leak branch from ce92811 to 9f61a5b Compare April 23, 2023 03:48
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2962 (b90efc1) into develop (b86f5c8) will increase coverage by 0.01%.
The diff coverage is 77.27%.

❗ Current head b90efc1 differs from pull request most recent head bf59420. Consider uploading reports for the commit bf59420 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2962      +/-   ##
=============================================
+ Coverage      64.72%   64.73%   +0.01%     
- Complexity      4880     4882       +2     
=============================================
  Files            554      555       +1     
  Lines          20217    20204      -13     
  Branches        1081     1080       -1     
=============================================
- Hits           13085    13080       -5     
+ Misses          6501     6493       -8     
  Partials         631      631              
Impacted Files Coverage Δ
...com/faforever/client/fx/ToStringOnlyConverter.java 0.00% <0.00%> (ø)
...om/faforever/client/game/GameDetailController.java 90.29% <50.00%> (+0.51%) ⬆️
...m/faforever/client/game/CustomGamesController.java 60.41% <93.75%> (+1.92%) ⬆️
...ver/client/game/GamesTilesContainerController.java 68.00% <100.00%> (+1.98%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a72c8f...bf59420. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 2cb56a7 into develop Apr 23, 2023
3 checks passed
@Sheikah45 Sheikah45 deleted the bugfix/games-controller-leak branch April 23, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAF client freezing and crashing when switching between tables and tiles in rapid succession
1 participant