Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make properties sortable #2972

Merged
merged 1 commit into from
May 10, 2023
Merged

Make properties sortable #2972

merged 1 commit into from
May 10, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2972 (f8dae90) into develop (ed3b029) will decrease coverage by 0.01%.
The diff coverage is 83.92%.

❗ Current head f8dae90 differs from pull request most recent head 9b43b11. Consider uploading reports for the commit 9b43b11 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2972      +/-   ##
=============================================
- Coverage      62.15%   62.14%   -0.01%     
- Complexity      4698     4700       +2     
=============================================
  Files            557      557              
  Lines          20303    20298       -5     
  Branches        1065     1061       -4     
=============================================
- Hits           12619    12615       -4     
- Misses          7076     7079       +3     
+ Partials         608      604       -4     
Impacted Files Coverage Δ
...a/com/faforever/client/map/MapVaultController.java 66.66% <ø> (ø)
...aforever/client/query/SpecificationController.java 83.15% <0.00%> (ø)
...aforever/client/vault/search/SearchController.java 55.65% <46.66%> (-0.39%) ⬇️
...main/java/com/faforever/client/map/MapService.java 70.44% <100.00%> (-0.60%) ⬇️
...main/java/com/faforever/client/mod/ModService.java 76.38% <100.00%> (ø)
...rever/client/query/SearchablePropertyMappings.java 98.18% <100.00%> (+1.63%) ⬆️
...ava/com/faforever/client/replay/ReplayService.java 80.73% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3b029...9b43b11. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 8cab3e4 into develop May 10, 2023
5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/sortables branch May 10, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant