Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing notifications for chat #3101

Merged
merged 4 commits into from
Dec 26, 2023
Merged

Add typing notifications for chat #3101

merged 4 commits into from
Dec 26, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 121 lines in your changes are missing coverage. Please review.

Comparison is base (4449ff9) 58.76% compared to head (51b18b2) 59.06%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3101      +/-   ##
=============================================
+ Coverage      58.76%   59.06%   +0.29%     
- Complexity      4392     4412      +20     
=============================================
  Files            563      565       +2     
  Lines          20189    20104      -85     
  Branches        1011      996      -15     
=============================================
+ Hits           11864    11874      +10     
+ Misses          7797     7716      -81     
+ Partials         528      514      -14     
Files Coverage Δ
...om/faforever/client/chat/ChannelTabController.java 90.12% <100.00%> (+6.49%) ⬆️
...ava/com/faforever/client/chat/ChatChannelUser.java 90.90% <100.00%> (+1.16%) ⬆️
...java/com/faforever/client/chat/ChatController.java 32.91% <ø> (+2.67%) ⬆️
...in/java/com/faforever/client/chat/ChatService.java 0.00% <ø> (ø)
...forever/client/chat/MatchmakingChatController.java 100.00% <100.00%> (+39.58%) ⬆️
...aforever/client/chat/PrivateChatTabController.java 100.00% <100.00%> (+36.36%) ⬆️
...in/java/com/faforever/client/chat/TypingState.java 100.00% <100.00%> (ø)
...ain/java/com/faforever/client/domain/GameBean.java 89.65% <100.00%> (-0.09%) ⬇️
...ent/teammatchmaking/TeamMatchmakingController.java 85.18% <ø> (-0.68%) ⬇️
...in/java/com/faforever/client/chat/ChatChannel.java 96.82% <94.87%> (+21.31%) ⬆️
... and 3 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4449ff9...51b18b2. Read the comment docs.

@Sheikah45 Sheikah45 marked this pull request as ready for review December 26, 2023 22:43
@Sheikah45 Sheikah45 merged commit 8fc7d7f into develop Dec 26, 2023
4 of 5 checks passed
@Sheikah45 Sheikah45 deleted the feature/irc-typing branch December 26, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant