Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server notifications to be displayed #3103

Merged
merged 2 commits into from Dec 27, 2023

Conversation

Sheikah45
Copy link
Member

Closes #3097

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8fc7d7f) 59.02% compared to head (dbfa148) 59.04%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3103      +/-   ##
=============================================
+ Coverage      59.02%   59.04%   +0.02%     
  Complexity      4410     4410              
=============================================
  Files            565      565              
  Lines          20104    20104              
  Branches         996      996              
=============================================
+ Hits           11866    11871       +5     
+ Misses          7722     7719       -3     
+ Partials         516      514       -2     
Files Coverage Δ
...rever/client/notification/NotificationService.java 23.63% <0.00%> (-9.10%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc7d7f...dbfa148. Read the comment docs.

@Sheikah45 Sheikah45 merged commit fa92110 into develop Dec 27, 2023
4 of 5 checks passed
@Sheikah45 Sheikah45 deleted the bugfix/server-notification branch December 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban message fails to display during login
1 participant