Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use server state to mark players as offline #3104

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

Sheikah45
Copy link
Member

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (d8c11ad) 58.95% compared to head (05fbae0) 58.97%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3104      +/-   ##
=============================================
+ Coverage      58.95%   58.97%   +0.02%     
- Complexity      4381     4395      +14     
=============================================
  Files            567      568       +1     
  Lines          20006    20038      +32     
  Branches         983      983              
=============================================
+ Hits           11795    11818      +23     
- Misses          7700     7707       +7     
- Partials         511      513       +2     
Files Coverage Δ
.../faforever/client/chat/ChatUserItemController.java 63.97% <100.00%> (ø)
...orever/client/filter/ChatUserFilterController.java 84.09% <100.00%> (+2.03%) ⬆️
...rever/client/fx/contextmenu/WatchGameMenuItem.java 100.00% <100.00%> (ø)
...va/com/faforever/client/game/PlayerGameStatus.java 100.00% <100.00%> (ø)
...ever/client/leaderboard/LeaderboardController.java 91.04% <100.00%> (ø)
...main/java/com/faforever/client/map/MapService.java 71.30% <100.00%> (-0.30%) ⬇️
...java/com/faforever/client/player/ServerStatus.java 100.00% <100.00%> (ø)
...ent/teammatchmaking/PartyMemberItemController.java 80.23% <100.00%> (ø)
...in/java/com/faforever/client/domain/PartyBean.java 83.87% <50.00%> (ø)
...er/client/fx/contextmenu/InvitePlayerMenuItem.java 83.33% <0.00%> (ø)
... and 6 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c11ad...05fbae0. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 2a69b63 into develop Jan 5, 2024
4 of 5 checks passed
@Sheikah45 Sheikah45 deleted the feature/player-state branch January 5, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant