Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non webview based chat #3106

Merged
merged 12 commits into from Jan 5, 2024
Merged

Use non webview based chat #3106

merged 12 commits into from Jan 5, 2024

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (5067d5e) 59.08% compared to head (7f43e05) 58.99%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3106      +/-   ##
=============================================
- Coverage      59.08%   58.99%   -0.10%     
+ Complexity      4416     4385      -31     
=============================================
  Files            565      567       +2     
  Lines          20122    20006     -116     
  Branches         990      983       -7     
=============================================
- Hits           11889    11802      -87     
+ Misses          7716     7694      -22     
+ Partials         517      510       -7     
Files Coverage Δ
...forever/client/chat/AbstractChatTabController.java 46.51% <ø> (ø)
...in/java/com/faforever/client/chat/ChatChannel.java 96.92% <100.00%> (+0.09%) ⬆️
.../com/faforever/client/chat/emoticons/Emoticon.java 100.00% <100.00%> (+25.00%) ⬆️
...ever/client/chat/emoticons/EmoticonController.java 100.00% <100.00%> (ø)
...aforever/client/chat/emoticons/EmoticonsGroup.java 100.00% <100.00%> (+25.00%) ⬆️
...lient/chat/emoticons/EmoticonsGroupController.java 100.00% <100.00%> (ø)
...r/client/filter/FilterMultiCheckboxController.java 87.03% <100.00%> (ø)
...ver/client/filter/MutableListFilterController.java 92.59% <100.00%> (ø)
...om/faforever/client/login/OAuthValuesReceiver.java 84.61% <100.00%> (+0.24%) ⬆️
...lient/map/management/MapsManagementController.java 75.86% <100.00%> (ø)
... and 12 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5067d5e...7f43e05. Read the comment docs.

@Sheikah45 Sheikah45 marked this pull request as ready for review January 2, 2024 03:21
@Sheikah45 Sheikah45 merged commit d8c11ad into develop Jan 5, 2024
5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/chat-ui-overhaul branch January 5, 2024 22:06
@micheljung
Copy link
Member

@Sheikah45 why was this done? I feel like the chat experience got way worse because of this.

@Sheikah45
Copy link
Member Author

This was done to allow for replies and reactions in the chat.

And to make the event handling and tooltips more uniform.

Some issues appeared for some users with scrolling where permanent fixes are still being investigated.

Additionally there were memory issues with the webview and how the chat state was handled so this was also used to clean all that up as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants