Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking of chat messages #3110

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (2a69b63) 58.99% compared to head (723ec3e) 58.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3110   +/-   ##
==========================================
  Coverage      58.99%   58.99%           
- Complexity      4394     4399    +5     
==========================================
  Files            568      568           
  Lines          20038    20067   +29     
  Branches         983      982    -1     
==========================================
+ Hits           11821    11839   +18     
- Misses          7703     7715   +12     
+ Partials         514      513    -1     
Files Coverage Δ
...m/faforever/client/chat/ChatMessageController.java 90.00% <100.00%> (+0.46%) ⬆️
...in/java/com/faforever/client/chat/ChatService.java 0.00% <ø> (ø)
...aforever/client/chat/PrivateChatTabController.java 100.00% <100.00%> (ø)
...in/java/com/faforever/client/chat/ChatMessage.java 88.88% <88.88%> (-11.12%) ⬇️
...com/faforever/client/chat/ChatMessageItemCell.java 0.00% <0.00%> (ø)
...forever/client/chat/ChatMessageViewController.java 62.04% <66.66%> (-1.08%) ⬇️
...in/java/com/faforever/client/chat/ChatChannel.java 93.33% <80.00%> (-3.59%) ⬇️
...a/com/faforever/client/chat/KittehChatService.java 70.95% <61.01%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a69b63...723ec3e. Read the comment docs.

@Sheikah45 Sheikah45 merged commit d927569 into develop Jan 6, 2024
5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/chat-message-tracking branch January 6, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant