Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reaction and reply capability to chat messages #3111

Merged
merged 4 commits into from Jan 10, 2024

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 162 lines in your changes are missing coverage. Please review.

Comparison is base (e9285eb) 59.00% compared to head (ac4880c) 59.21%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3111      +/-   ##
=============================================
+ Coverage      59.00%   59.21%   +0.21%     
- Complexity      4401     4468      +67     
=============================================
  Files            568      574       +6     
  Lines          20067    20405     +338     
  Branches         982     1007      +25     
=============================================
+ Hits           11840    12083     +243     
- Misses          7715     7788      +73     
- Partials         512      534      +22     
Files Coverage Δ
...om/faforever/client/chat/ChannelTabController.java 90.12% <100.00%> (ø)
...in/java/com/faforever/client/chat/ChatService.java 0.00% <ø> (ø)
.../faforever/client/chat/ChatUserItemController.java 63.97% <100.00%> (ø)
.../com/faforever/client/chat/emoticons/Emoticon.java 100.00% <100.00%> (ø)
...aforever/client/chat/emoticons/EmoticonsGroup.java 100.00% <100.00%> (ø)
.../com/faforever/client/chat/emoticons/Reaction.java 100.00% <100.00%> (ø)
.../java/com/faforever/client/fx/BrowserCallback.java 66.66% <ø> (+52.38%) ⬆️
.../main/java/com/faforever/client/fx/Controller.java 93.33% <100.00%> (ø)
...va/com/faforever/client/fx/MenuItemController.java 100.00% <100.00%> (ø)
...n/java/com/faforever/client/fx/NodeController.java 77.77% <100.00%> (ø)
... and 25 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9285eb...ac4880c. Read the comment docs.

@Sheikah45 Sheikah45 force-pushed the feature/replies-and-reactions branch from 8d65c11 to d05b43d Compare January 8, 2024 02:19
@Sheikah45 Sheikah45 force-pushed the feature/replies-and-reactions branch from 2771e13 to 426a539 Compare January 10, 2024 00:55
@Sheikah45 Sheikah45 marked this pull request as ready for review January 10, 2024 02:58
@Sheikah45 Sheikah45 merged commit dc1c11a into develop Jan 10, 2024
4 of 5 checks passed
@Sheikah45 Sheikah45 deleted the feature/replies-and-reactions branch January 10, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant