Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to FAF Client README #3123

Merged
merged 2 commits into from Feb 10, 2024
Merged

Updates to FAF Client README #3123

merged 2 commits into from Feb 10, 2024

Conversation

NicPWNs
Copy link
Contributor

@NicPWNs NicPWNs commented Feb 6, 2024

  1. First, saw that the YourKit logo was broken, so fixed that.
  2. Fixed other grammatical and formatting issues while here.

Please let me know if there's anything else needed for this PR, or if there's any other doc-related items that should be updated here.

@Sheikah45 Sheikah45 enabled auto-merge (squash) February 10, 2024 19:54
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61b5567) 58.93% compared to head (d50e140) 58.91%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3123      +/-   ##
=============================================
- Coverage      58.93%   58.91%   -0.02%     
+ Complexity      4479     4478       -1     
=============================================
  Files            574      574              
  Lines          20532    20532              
  Branches        1018     1018              
=============================================
- Hits           12100    12096       -4     
- Misses          7897     7901       +4     
  Partials         535      535              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b5567...d50e140. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 37795c7 into FAForever:develop Feb 10, 2024
4 checks passed
@NicPWNs NicPWNs deleted the patch-1 branch February 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants