Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay card controller tests #3124

Merged
merged 3 commits into from Feb 19, 2024

Conversation

obydog002
Copy link
Contributor

Add tests for ReplayCardController

withThreeTeamsShowClickForMore is intermittently failing, think its an issue with a race condition but unsure how to fix

@obydog002 obydog002 changed the title WIP: Replay card controller tests Replay card controller tests Feb 19, 2024
@obydog002
Copy link
Contributor Author

Removed the intermittent test, let me know if there is any else I should test

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (382a5f3) 58.92% compared to head (e98c55c) 59.40%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3124      +/-   ##
=============================================
+ Coverage      58.92%   59.40%   +0.48%     
- Complexity      4481     4506      +25     
=============================================
  Files            574      574              
  Lines          20535    20535              
  Branches        1019     1019              
=============================================
+ Hits           12100    12199      +99     
+ Misses          7900     7797     -103     
- Partials         535      539       +4     
Files Coverage Δ
.../faforever/client/replay/ReplayCardController.java 82.24% <ø> (+82.24%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382a5f3...e98c55c. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 3f421df into FAForever:develop Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants