Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make api objects immutable #3140

Merged
merged 31 commits into from Mar 2, 2024
Merged

Make api objects immutable #3140

merged 31 commits into from Mar 2, 2024

Conversation

Sheikah45
Copy link
Member

No description provided.

@Sheikah45 Sheikah45 force-pushed the maintenance/immutable-beans branch from fee3c0a to cfa3fd1 Compare March 2, 2024 23:52
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 72.53470% with 376 lines in your changes are missing coverage. Please review.

Project coverage is 58.73%. Comparing base (05eea7a) to head (cfa3fd1).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3140      +/-   ##
=============================================
- Coverage      59.54%   58.73%   -0.82%     
+ Complexity      4465     3990     -475     
=============================================
  Files            576      574       -2     
  Lines          20677    19203    -1474     
  Branches        1005     1013       +8     
=============================================
- Hits           12312    11278    -1034     
+ Misses          7837     7433     -404     
+ Partials         528      492      -36     
Files Coverage Δ
.../java/com/faforever/client/api/FafApiAccessor.java 90.12% <100.00%> (+0.06%) ⬆️
.../main/java/com/faforever/client/avatar/Avatar.java 100.00% <100.00%> (ø)
...ava/com/faforever/client/avatar/AvatarService.java 100.00% <100.00%> (ø)
...ava/com/faforever/client/chat/ChatChannelUser.java 90.90% <100.00%> (ø)
...m/faforever/client/chat/ChatMessageController.java 79.89% <100.00%> (-0.33%) ⬇️
...a/com/faforever/client/chat/KittehChatService.java 72.76% <100.00%> (-0.11%) ⬇️
...forever/client/chat/MatchmakingChatController.java 100.00% <100.00%> (ø)
...aforever/client/chat/PrivateChatTabController.java 100.00% <100.00%> (ø)
...in/java/com/faforever/client/clan/ClanService.java 71.42% <100.00%> (-3.58%) ⬇️
...a/com/faforever/client/domain/api/CoopMission.java 100.00% <100.00%> (ø)
... and 176 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05eea7a...cfa3fd1. Read the comment docs.

@Sheikah45 Sheikah45 merged commit bd3b762 into develop Mar 2, 2024
4 of 5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/immutable-beans branch March 2, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant