Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Mappers #3141

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Simplify Mappers #3141

merged 4 commits into from
Mar 3, 2024

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 80.26316% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 58.70%. Comparing base (021f3aa) to head (a3f08fc).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3141      +/-   ##
=============================================
- Coverage      58.76%   58.70%   -0.06%     
+ Complexity      3990     3955      -35     
=============================================
  Files            574      573       -1     
  Lines          19198    19164      -34     
  Branches        1013     1013              
=============================================
- Hits           11282    11251      -31     
+ Misses          7424     7423       -1     
+ Partials         492      490       -2     
Files Coverage Δ
...ava/com/faforever/client/avatar/AvatarService.java 100.00% <100.00%> (ø)
...in/java/com/faforever/client/clan/ClanService.java 66.66% <100.00%> (-4.77%) ⬇️
...in/java/com/faforever/client/coop/CoopService.java 72.72% <100.00%> (-1.19%) ⬇️
...ain/java/com/faforever/client/domain/api/Clan.java 100.00% <ø> (+33.33%) ⬆️
...va/com/faforever/client/domain/api/ModVersion.java 100.00% <ø> (ø)
...forever/client/leaderboard/LeaderboardService.java 100.00% <100.00%> (ø)
...ava/com/faforever/client/mapstruct/ClanMapper.java 0.00% <ø> (-75.00%) ⬇️
...ava/com/faforever/client/mapstruct/GameMapper.java 57.14% <ø> (-5.36%) ⬇️
...om/faforever/client/mapstruct/IceServerMapper.java 100.00% <ø> (ø)
...java/com/faforever/client/mapstruct/MapMapper.java 75.00% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021f3aa...a3f08fc. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 3841761 into develop Mar 3, 2024
5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/simplify-mappers branch March 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant