Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent working directory for client #3143

Merged

Conversation

obydog002
Copy link
Contributor

Fixes #3100

The issue was because the faf client was being opened with the wrong working directory and it could not find the resource files/ binaries it needs to start correctly. This change to the install4j installer file seems to let the faf client consistently have the correct working directory (which is the installation path) no matter how it gets called.

Testing

Linux

  • Opening the client from the same and different directories starts the client normally.
  • Opening the client from the same and different directories along with a path to a replay file starts the client and launches the replay.

Windows

  • Opening a faf replay via right click starts the client and launches the replay.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.67%. Comparing base (519eeb5) to head (936d0f2).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3143      +/-   ##
=============================================
+ Coverage      58.62%   58.67%   +0.05%     
- Complexity      3949     3951       +2     
=============================================
  Files            573      573              
  Lines          19164    19164              
  Branches        1013     1013              
=============================================
+ Hits           11235    11245      +10     
+ Misses          7440     7429      -11     
- Partials         489      490       +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519eeb5...936d0f2. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 92a86a0 into FAForever:develop Mar 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client gets stuck infinitely logging in if it's opened by double clicking on a replay file
2 participants