Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text on search button #3157

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Change text on search button #3157

merged 1 commit into from
Apr 13, 2024

Conversation

BlackYps
Copy link
Collaborator

@BlackYps BlackYps commented Apr 6, 2024

Changes the text on the search button that is used in the matchmaker tab.
Apparently people regularly don't realize that they need to press this button to actually start searching, so the text is more explicit now.

Btw, do existing translations automatically get some sort of mark that the original text has changed and they need retranslation?

@BlackYps BlackYps requested a review from Sheikah45 April 6, 2024 20:19
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.86%. Comparing base (60c84a7) to head (de3d17d).

❗ Current head de3d17d differs from pull request most recent head d8b44d2. Consider uploading reports for the commit d8b44d2 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3157      +/-   ##
=============================================
+ Coverage      58.84%   58.86%   +0.02%     
  Complexity      3986     3986              
=============================================
  Files            576      576              
  Lines          19296    19290       -6     
  Branches        1022     1019       -3     
=============================================
+ Hits           11355    11356       +1     
+ Misses          7446     7439       -7     
  Partials         495      495              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c84a7...d8b44d2. Read the comment docs.

@Sheikah45
Copy link
Member

They do not that is why a new key should be used instead of reusing an old one.

@Sheikah45 Sheikah45 merged commit dd9ab2b into develop Apr 13, 2024
3 checks passed
@Sheikah45 Sheikah45 deleted the play-button-text branch April 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants