Change generator UI for the new map generator version #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
requested changes
May 29, 2024
src/main/java/com/faforever/client/game/GenerateMapController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/game/GenerateMapController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/game/GenerateMapController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/game/GenerateMapController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/generator/GeneratorCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/map/generator/GeneratorOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/preferences/GeneratorPrefs.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/game/GenerateMapController.java
Outdated
Show resolved
Hide resolved
|
Do you have an idea why there is excessive space between the heading and the spawn number spinner? It's not because of the hidden command line field, because even if I enable that, there is still too much space under the heading. |
|
I never was exactly sure, something with the gridpane I think |
|
There is a weird interaction going on. When the heading text is the longest of all elements in the column, then it needs significantly more vertical space. This can easily be observed by shortening the text. I have no idea why this happens though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are changing the parameters for the map generator here: FAForever/Neroxis-Map-Generator#396