Implement the repository URL #3192
Conversation
| // retrieve information from the mod_info.lua to send to the API | ||
| ModVersion modVersion = extractModInfo(modPath); | ||
| modUploadTask.setRepositoryURL(modVersion.mod().repositoryURL()); |
There was a problem hiding this comment.
This can be moved into the ModUploadTask itself
| // retrieve information from the mod_info.lua to send to the API | ||
|
|
||
| ModVersion modVersionInfo = modService.extractModInfo(modPath); | ||
| URL repositoryURL = modVersionInfo.mod().repositoryURL(); |
There was a problem hiding this comment.
This is shadowing the field repositoryUrl now. So the field should be removed or this should set the field if it is null.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3192 +/- ##
=============================================
- Coverage 58.83% 58.50% -0.33%
- Complexity 3984 4085 +101
=============================================
Files 576 581 +5
Lines 19296 19791 +495
Branches 1022 1035 +13
=============================================
+ Hits 11353 11579 +226
- Misses 7447 7707 +260
- Partials 496 505 +9
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| runOnFxThreadAndWait(() -> instance.setModVersion(modVersion)); | ||
| WaitForAsyncUtils.waitForFxEvents(); |
There was a problem hiding this comment.
technically you don't need WaitForAsyncUtils.waitForFxEvents if you run things with runOnFxThreadAndWait
Relates to:
mod_info.luafaf-java-api#564It's shown as the 'Source' link, below the author. Visually it is not ideal, but we can improve that separately.