Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifetime of lobby in games table #3198

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Add lifetime of lobby in games table #3198

merged 6 commits into from
Jun 7, 2024

Conversation

Marc-Spector
Copy link
Collaborator

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.47%. Comparing base (dd9ab2b) to head (949a3d2).
Report is 26 commits behind head on develop.

Current head 949a3d2 differs from pull request most recent head 07eea84

Please upload reports for the commit 07eea84 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3198      +/-   ##
=============================================
- Coverage      58.83%   58.47%   -0.36%     
- Complexity      3984     4089     +105     
=============================================
  Files            576      581       +5     
  Lines          19296    19790     +494     
  Branches        1022     1035      +13     
=============================================
+ Hits           11353    11573     +220     
- Misses          7447     7712     +265     
- Partials         496      505       +9     
Files Coverage Δ
...om/faforever/client/game/GamesTableController.java 50.00% <66.66%> (+0.43%) ⬆️
...a/com/faforever/client/domain/server/GameInfo.java 88.52% <60.00%> (-1.22%) ⬇️
...ava/com/faforever/client/mapstruct/GameMapper.java 50.00% <0.00%> (-7.15%) ⬇️
...in/java/com/faforever/client/util/TimeService.java 39.39% <77.77%> (+39.39%) ⬆️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4b1ab...07eea84. Read the comment docs.

@Marc-Spector Marc-Spector marked this pull request as ready for review June 5, 2024 18:24
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that gives me a little pause is that the lifetime column is static so won't actually be updated unless we get an update from the game.

Part of me wonders if it should be guaranteed to be updated.

@Marc-Spector
Copy link
Collaborator Author

The only thing that gives me a little pause is that the lifetime column is static so won't actually be updated unless we get an update from the game.

Or we can switch to another tab and then back again to get the fresh result. Sorting the lifetime column. And much more

Part of me wonders if it should be guaranteed to be updated.

That's up to you. If it's necessary, then I need to figure out how to do it.

@Sheikah45
Copy link
Member

Yeah I guess if it updates that often then we will just see if anyone complains about it

@Sheikah45 Sheikah45 merged commit af932e4 into develop Jun 7, 2024
3 checks passed
@Sheikah45 Sheikah45 deleted the feature/hostedAt branch June 7, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lobby Hosting Duration Indicator
2 participants