-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lifetime of lobby in games table #3198
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3198 +/- ##
=============================================
- Coverage 58.83% 58.47% -0.36%
- Complexity 3984 4089 +105
=============================================
Files 576 581 +5
Lines 19296 19790 +494
Branches 1022 1035 +13
=============================================
+ Hits 11353 11573 +220
- Misses 7447 7712 +265
- Partials 496 505 +9
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that gives me a little pause is that the lifetime column is static so won't actually be updated unless we get an update from the game.
Part of me wonders if it should be guaranteed to be updated.
Or we can switch to another tab and then back again to get the fresh result. Sorting the lifetime column. And much more
That's up to you. If it's necessary, then I need to figure out how to do it. |
Yeah I guess if it updates that often then we will just see if anyone complains about it |
949a3d2
to
07eea84
Compare
Requests FAForever/faf-java-commons#152
Closes #3054