Feature/#333 open fafreplay #857
Conversation
ghost
assigned 
micheljung
force-pushed
the
feature/#333-open-fafreplay
branch
2 times, most recently
from
f01f5c2
to
b7a9da4
Compare
micheljung
force-pushed
the
feature/#333-open-fafreplay
branch
from
b7a9da4
to
39ed5ea
Compare
|
You really wann have the 5$ right ;), what if I right click on the file and say open with when the client is already running? |
| private void onStartup(String parameters) { | ||
| log.debug("Handling startup: {}", parameters); | ||
| if (parameters.split("\" \"").length > 2) { | ||
| throw new IllegalArgumentException("Can't handle multiple files: " + parameters); |
There was a problem hiding this comment.
Exceptions don't support string formatting. I had to do:
throw new IllegalArgumentException(String.format("Can't handle multiple files: %s", parameters));
but with simple concatenations like this, I don't see the benefit. With more/complex parameters, I would agree.
| package com.faforever.client.os; | ||
|
|
||
| import com.faforever.client.replay.ReplayService; | ||
| import com.install4j.api.launcher.StartupNotification; |
| private void onStartup(String parameters) { | ||
| log.debug("Handling startup: {}", parameters); | ||
| if (parameters.split("\" \"").length > 2) { | ||
| throw new IllegalArgumentException("Can't handle multiple files: " + parameters); |
There was a problem hiding this comment.
Exceptions don't support string formatting. I had to do:
throw new IllegalArgumentException(String.format("Can't handle multiple files: %s", parameters));
but with simple concatenations like this, I don't see the benefit. With more/complex parameters, I would agree.
Then it will start the replay |
No description provided.