Add terrain avoidance to tempest (proper branch) #1367
Conversation
so this uses a slider to transform the unit model. looks great. what this doesnt do probably: change hitbox change the units position as far as game is concerned change anything except the model work properly in a normal game
now this is more of a terrain avoidance thing than anything else. it sinks a little bit below its original depth and raises a little bit above its original depth when above terrain. - should probably work in a normal game as is - no need to adjust unit position when movement is this small - code is probably a mess but looks like it works.
should be done now. #HopeForTheBest #FixedInEquilibrium #DontNegotiateWithBalanceTerrorists
|
This PR doesn't seem to include the new animation? |
|
Or am I getting this confused with the HARMS stuff like the nooblet I am? :D |
|
@Zockyzock Do we classify this as a fix? This code allows them to go below ground-fire range. |
|
@aeoncleanse "them" is tempests, or all subs? The possibility to ground fire on underwater units need to be consistent. (until some potential changes happen to ground fire in far future) If this change makes tempest not groundfireable, but subs still are, its maybe something for the future, but not yet. If its a very rare occation to be not groundfireable, it needs to be weighted against how often the torpedo bug happens. |
|
This affects tempest and atlantis only |
|
does this PR fixes issue with multiple tempest units stop moving when they colliding with each other? |
|
i guess some clarification is needed - this elevates the model above the seabed when it gets too shallow. it doesnt actually make them go deeper, just adds the ability to do so. by elevating them above the seafloor it means they clip through the ground less, and thats a good thing because their torpedo tubes are not stopped from firing (as much) their position is unchanged, and so pathfinding is completely unaffected (and very hard to fix) this is a bug fix. not a balance change. It could be applied to all submerged units if needed, however since the hitbox is unmoved it doesnt affect groundfire at all, and smaller units need this code less. these two are so big they have the most issues and just so you know groundfiring is extremely inconsistent anyway due to the way the game sets elevation. (its absuuuuuuurd) |
|
So submerging in the first place works, but if you go into a shallow area and out again, it won't re-dive properly. What's up? |
|
thats engine stuff if you mean actual unit position. was always present. very annoying but sadly true. i tried fixing that before making this fix, and failed miserably. the slider is not very long since unit position itself cant change (because of aforementioned engine things) so it doesnt fix that issue, but does make it a little better, if only a little. if you mean the slider gets stuck somehow then i have no idea at all. |
|
Well, if the unit comes up for beaches or whatever, but then gets stuck at a higher-than-normal elevation unless you toggle the submerge button off and on, this entire PR just seems pointless... Am I wrong? |
|
no you are wrong. this pr is purely a bugfix for the torpedo tubes getting stuck in the terrain. thats all it does, via animations (animations dont change the position of the unit, at all, so they are not affected by this engine stuff). if the unit gets to shallow water thats pretty much guaranteed to happen, regardless of whether it will go back down or not. the slightly going down partial fix there, its kinda a nice side effect and not the purpose of this. |
|
You're using sliders. These change the physical location of the unit mesh... There is no animation change here.. |
|
sliders are animators but simple ones, in any case the point is the mesh is changed but not the unit position (hitbox, meshextents, lifebars, ect) |
(this one is from a nicer branch for me, but otherwise identical to #1360)
it moves up when over terrain so its torpedo tubes dont clip into it and stop firing. when moving into deeper water it moves down a little bit, but not too much.
This is on a slider. this means the actual position of the unit doesn't change, so its ok for small movement but making it move way deeper would need more work.