New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more french #2355
more french #2355
Conversation
some lines are still missing - will update when i get them |
loc/FR/strings_db.lua
Outdated
loadingtip_0006="Améliorez vos extracteurs en Tech 2 avant de construire des stockages de masse." | ||
loadingtip_0007="Un UBC immergé est toujours plus difficile à repérer ou à assassiner. Si vous ne pouvez pas protéger l'UBC en fin de partie, cachez-le." | ||
loadingtip_0008="Un missile stratégique (\"nuke\") se construit en 5 minutes : l'anti-missile, lui, se construit en 4 minutes." | ||
loadingtip_0009="Utilisez l'ordre \"Se déplacer en attaquant\" depuis une usine augmente la portée de recyclage des ingénieurs produits, le temps de l'execution de l'ordre." ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ###
at the end of this line
this is whats failing the tests
loc/FR/strings_db.lua
Outdated
teamkill_0002 = "Vous avez été tué par un tir allié. L'assassinat délibéré de coéquipiers est proscrit par le règlement de FA Forever. Si vous considérez que votre défaite était délibérée ou déloyale, appuyez sur le bouton ci-dessous pour le signaler." | ||
teamkill_0003 = "Signaler" | ||
teamkill_0004 = "Pardonner" | ||
|
||
# part added by retard for additional completion and stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could also change all the comments from #
to --
Here is the updated version ! |
took rackovers new version and updated the PR |
updated the PR with more suggested changes |
i've done another checking, will need one more checking/testing by changing loc.nx2 file (and putting them as read only) since i can't get the faf setting by using the console + starting the game localy. |
Rechecked along with @shalkya , new version here, awaiting another check. Also know that a lot of faf-content cannot be translated as it's not present in the loc files. This represents a handful of lines, maybe 10 or 15. Not much compared to the 700+ translated lines here, so it shouldn't be any problem. I contacted keyser for re-check, but anyone else can do it too. But please please don't send me lines to translate that are not present in the locfile. Check for line presence in the US / FR loc file before sending it to me : if the line is not there, i cannot translate it. |
replaced the file with the one that keyser sent me
@@ -1,6 +1,10 @@ | |||
# autogenerated file - DO NOT EDIT THIS FILE UNDER ANY CIRCUMSTANCES | |||
# USE LocStrings.xls INSTEAD TO EDIT STRINGS | |||
|
|||
--[[ | |||
r: FAF Translation starts on line 7656 | |||
--]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't seem pointful?
Git blame can tell you everything you need to know, and that line number seems likely to end up being made incorrect as time goes on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it then. I just put it here to make reviewing the translation easier, as the translation I made is mixed up with the official FA translation, itself mixed up with the original SC1 translation. This notice allows to distinguish the fan-made translation from the rest : i even added a banner around that line to help acknowledging the separation. If you think this comment is pointless however, feel free to remove it!
Dont hesitate to contact me on slack if you have any other question or remark regarding this file, by the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont hesitate to contact me on slack if you have any other question or remark regarding this file, by the way.
Just a drive-by review, I'm afraid. I know exactly enough French to ask people if they speak English ;)
translation provided by discord user
Rackover#2107
please check for errors if you can (i can't read any french)
rackover at racknet.noip.me is their address if you want to talk to them directly