Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invulnerable sub-carried units #2811

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Conversation

aeoncleanse
Copy link
Member

  • Load unit into Stinger
  • Load Stinger into any Naval Aircraft Carrier (Czar doesn't work)
  • When Carrier dies, we get invulnerable, invisible units capable of attacking

This was caused by the engine Kill() command calling SetDead() before the detach/kill code was called, so the if not self.Dead safety check backfired and prevented the proper handling.

This PR refactors some duplicated loop code, moves it into BaseTransport for inheritance, and adds a Kill() override to AircraftCarrier, fixing the bug.

Please test as many combinations of units inside units inside units as you can think of. Of concern I don't have time to check right now:

  • Fatboy
  • Air Staging

@aeoncleanse aeoncleanse added this to the 3706 milestone Jul 8, 2019
@shalkya shalkya changed the title Fix invlunerable sub-carried units Fix invulnerable sub-carried units Jul 9, 2019
@PhilipJFryFAF PhilipJFryFAF modified the milestones: 3706, 3707 Jul 14, 2019
@aeoncleanse aeoncleanse merged commit 5c544d2 into deploy/fafdevelop Jul 15, 2019
@aeoncleanse aeoncleanse deleted the fix_invuln_units branch July 15, 2019 02:34
@PhilipJFryFAF
Copy link
Contributor

tested:

  • loading an aurora into a stinger
  • loading the stinger with the aurora into an atlantis or czar
  • destroying the atlantis/czar via self destruct or instant self destruct

when killing the carrier via instant self destruct we still have the invisible/invincible aurora being left behind

when killing a transport with units loaded via self destruct then the loaded units will not die anymore

will need someone to fix both issues since a) the PR doesn't fix what it says it does and b) introduce a new bug

@shalkya
Copy link
Member

shalkya commented Oct 19, 2019

i cannot replicate the bug in normal faf.
1- load T2 tank into stinger
2- load stinger into atlantis or aircraft carrier
3- ctrl k aircraft carrier/atlantis (also during the unloading)
4- all units are dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants