Fix invulnerable sub-carried units #2811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by the engine Kill() command calling SetDead() before the detach/kill code was called, so the
if not self.Dead
safety check backfired and prevented the proper handling.This PR refactors some duplicated loop code, moves it into BaseTransport for inheritance, and adds a Kill() override to AircraftCarrier, fixing the bug.
Please test as many combinations of units inside units inside units as you can think of. Of concern I don't have time to check right now: