Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target bones of Cybran T2 Land HQ #2817

Conversation

speed2CZ
Copy link
Member

@speed2CZ speed2CZ commented Jul 14, 2019

Could fix Fixes #2784

The BP has a target bone from a T1 factory.

Comparing visually the position of the bones, this could fix the issue.

Untested, go crazy.

@speed2CZ speed2CZ added the area: unit-blueprint related to issues in unit blueprints (*_unit.bp) label Jul 14, 2019
@speed2CZ speed2CZ changed the title Fix target bones Fix target bones of Cybran T2 Land HQ Jul 14, 2019
@PhilipJFryFAF PhilipJFryFAF added this to the 3707 milestone Jul 14, 2019
@aeoncleanse
Copy link
Member

Hmmm. All these choices for target bone seem odd. May I ask that you increased the size of the collision box to better match the visuals please, it's much too small, and then add AttachPoint to the top of the bone list? That I'm confident will fully bring this up to standard.

@speed2CZ
Copy link
Member Author

The hitbox is not bigger in T3 hq so I rather not do that. I didnt add any bones or stuff, I just looked in the game what they names and positions and I think this could help

@aeoncleanse
Copy link
Member

Sounds to me like the boxes of all of them could use matching to their visuals then, if you're feeling adventurous.

Please add AttachPoint to the top of the list though, as well as changing it to use the right unit ID. AttachPoint is centrally located above the base bone, and IMO is the best target choice. Will help with things targeting it in adverse terrain as well.

@speed2CZ
Copy link
Member Author

T1 and T3 factory doesn't seem to have this issue. Or at least it wasnt reported. So if this fix help, I would rather not mess with the hitboxes

@aeoncleanse
Copy link
Member

Up to you to mess with the box or not. Please add the additional bone to the list though!

@speed2CZ
Copy link
Member Author

I might but I would still prefer if someone tried if this improves it and then we can mess with it even further

@aeoncleanse
Copy link
Member

Oh for goodness sake...

@aeoncleanse aeoncleanse merged commit 24d5da2 into FAForever:deploy/fafdevelop Jul 27, 2019
@speed2CZ speed2CZ deleted the fix/cybranT2LandFacTargetBones branch July 28, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit-blueprint related to issues in unit blueprints (*_unit.bp)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants