Fix ML exhaust effects playing during construction #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix doesn't seem right... Surely we should need to track down, and remove, the original call which creates the effect in the first place? |
|
It happens on layer change. You can see it in the script. Different effext for land and water layer. Problem is that its called right away when you start building it. Since it goea from no layer to land for example. |
|
So is the correct solution not to put a guard in place around the call to create effects, inside layerchange, to check completion, thereby fixing this bug in all units at once? |
|
What all units? It's a ML specific effect inside the ML script, where else would you want the check to be? |
|
Oh yes, I see now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396