Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup terran units file #2827

Merged
merged 4 commits into from
Sep 22, 2019

Conversation

speed2CZ
Copy link
Member

Some clean up + fix for UEF factory build arms

speed2 added 4 commits July 14, 2019 22:17
When factory was paused and unit queued for construction. Unpausing the
factory caused creating two threads for moving arms.
end
end,
}
TMassCollectionUnit = Class(MassCollectionUnit) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm you have checked that the UEF Mexes A: Definitely have animations for all stages of upgrade and B: Removing this definitely doesn't cause visual errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My quick check confirms that mexes do upgrade normally. The rest of testing is up to the test teeam

@PhilipJFryFAF PhilipJFryFAF added this to the 3708 milestone Jul 24, 2019
@shalkya
Copy link
Member

shalkya commented Sep 22, 2019

visually seems fine although i got this error that i had on version without the fix too.

WARNING: Error running OnPaused script in Entity ueb0302 at 1b6d2e08: ...documents\github\fa\units\ueb0302\ueb0302_script.lua(59): attempt to call method `SetGoal' (a nil value)
         stack traceback:
         	...documents\github\fa\units\ueb0302\ueb0302_script.lua(59): in function `StopArmsMoving'
         	...s\%USER%\documents\github\fa\lua\terranunits.lua(63): in function <...s\%USER%\documents\github\fa\lua\terranunits.lua:61>
WARNING: Error running OnPaused script in Entity zeb9602 at 21501b08: ...documents\github\fa\units\zeb9602\zeb9602_script.lua(59): attempt to call method `SetGoal' (a nil value)
         stack traceback:
         	...documents\github\fa\units\zeb9602\zeb9602_script.lua(59): in function `StopArmsMoving'
         	...s\%USER%\documents\github\fa\lua\terranunits.lua(63): in function <...s\%USER%\documents\github\fa\lua\terranunits.lua:61>

@speed2CZ
Copy link
Member Author

Those warnings are form the unit scripts, unrelated to this PR. Make a new issue for those please.

@shalkya shalkya merged commit a080a9d into FAForever:deploy/fafdevelop Sep 22, 2019
@speed2CZ speed2CZ deleted the cleanup/terranUnits branch December 14, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants