-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup terran units file #2827
Cleanup terran units file #2827
Conversation
When factory was paused and unit queued for construction. Unpausing the factory caused creating two threads for moving arms.
end | ||
end, | ||
} | ||
TMassCollectionUnit = Class(MassCollectionUnit) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm you have checked that the UEF Mexes A: Definitely have animations for all stages of upgrade and B: Removing this definitely doesn't cause visual errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My quick check confirms that mexes do upgrade normally. The rest of testing is up to the test teeam
visually seems fine although i got this error that i had on version without the fix too.
|
Those warnings are form the unit scripts, unrelated to this PR. Make a new issue for those please. |
Some clean up + fix for UEF factory build arms