Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoFill lobby slots #2842

Merged
merged 6 commits into from
Sep 28, 2019
Merged

AutoFill lobby slots #2842

merged 6 commits into from
Sep 28, 2019

Conversation

KionX
Copy link
Collaborator

@KionX KionX commented Aug 3, 2019

Adds the AutoFill feature slots lobby AI and their division into nth number of teams

Adds the AutoFill feature slots lobby AI and their division into nth number of teams
@PhilipJFryFAF
Copy link
Contributor

seems to work just fine - even supports AIs that are loaded via mods (eg. Uveso AI or Dilli)

@shalkya
Copy link
Member

shalkya commented Sep 22, 2019

would it be possible to add a message on hover especially for the number of team. It isn't obvious at first glance.

@shalkya
Copy link
Member

shalkya commented Sep 23, 2019

 `Teams Count`

How many teams should there be? (Players and AI will be split evenly between, will not work if the number of teams specified can't be divided into this number)

could you use this tooltip ? Is it too long ?
also can you make so when you can't divide (eg 8/3) then you it doesn't change or give a warning. I guess you can keep it like you did, but need to have a notification about that. Because putting 3 and getting 4 teams is weird.

@PhilipJFryFAF PhilipJFryFAF added this to the 3708 milestone Sep 27, 2019
@PhilipJFryFAF
Copy link
Contributor

@KionX i'd like to merge your PR but i'd prefer having the suggested changes from @shalkya in if possible

loc/US/strings_db.lua Outdated Show resolved Hide resolved
@shalkya shalkya merged commit d164648 into FAForever:deploy/fafdevelop Sep 28, 2019
@shalkya shalkya mentioned this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants