Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix air facto rebuild on wreck #2873

Merged
merged 1 commit into from
Oct 16, 2019
Merged

fix air facto rebuild on wreck #2873

merged 1 commit into from
Oct 16, 2019

Conversation

shalkya
Copy link
Member

@shalkya shalkya commented Oct 8, 2019

if a wreck was created (unit killed after 50% completion) air facto would start construction of the same unit with 50% done already.

fix #2386

if a wreck was created (unit killed after 50% completion) air facto would start construction of the same unit with 50% done already.
@shalkya shalkya added this to the 3708 milestone Oct 8, 2019
@shalkya shalkya requested review from Strogoo and removed request for aeoncleanse October 9, 2019 22:32
Copy link
Contributor

@Strogoo Strogoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@Nojoke185
Copy link

Checked the PR
Best I can tell, this looks to be working as designed

Test ran:

1 - build following air factories:

  • T1
  • T2HQ
  • T2Support
  • T3HQ
  • T3Support
    2 - at each air factory build an air unit to above 50% completed
    3 - before unit completed destroy it using enemy T1 bombers. A wreck is left
    4 - rebuild same type of air unit at air factory
    5 - ensure that the rebuild starts from 0% and not 50%
    6 - let rebuild complete, verify unit is operational
    7 - build another unit of same type
    8 - ensure that the rebuild starts from 0% and not 50%
    9 - let rebuild complete, verify unit is operational
    10 - build other types of air unit, verify unit is operational
    11 - verify no log errors

Test Results:
All units tested started at 0% for the rebuild
All units can be built to completion and function
Factory can cancel order or give new order and pause construction
Wreck is left and can be reclaimed
No log errors visible

Variations:
Test UEF, CYBRAN, SERA, AEON
Test a mix of different air units

Note:
Side effect of fix is that the part constructed unit leaves a wreck on air factory

@shalkya shalkya merged commit a715916 into deploy/fafdevelop Oct 16, 2019
@shalkya shalkya deleted the airfacto_rebuild branch October 16, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants