Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UEF Navy UI things #2980

Merged
merged 7 commits into from Feb 16, 2020
Merged

Fix UEF Navy UI things #2980

merged 7 commits into from Feb 16, 2020

Conversation

speed2CZ
Copy link
Member

@speed2CZ speed2CZ commented Feb 9, 2020 •
edited

  • Improves the positions of the Cruiser and Shield boat health bar.

  • Improves the selection thickness of the Shield boat.
    Before:
    ForgedAlliance_2020-02-09_09-41-26
    After:
    ForgedAlliance_2020-02-09_09-40-04

  • Fixes the position of the shield boat emitters
    Before:
    ForgedAlliance_2020-02-09_11-24-03
    After:
    ForgedAlliance_2020-02-09_11-23-14

  • Increased Shield boat idle effect (the white just around the ship)
    Before:
    ForgedAlliance_2020-02-09_11-57-15
    After:
    ForgedAlliance_2020-02-09_11-57-46

speed2 added 2 commits February 9, 2020 08:33
Adjust UEF Cruiser health bar
2b64dde 
- moved slightly closer to the ship
- reduced size
Now it's same as the destroyer
Adjust Stealth Boat Heatl Bar
93d1c2e 
Move slightly lower to follow the navy format
@speed2CZ speed2CZ added area: ui Anything to do with the User Interface of the Game area: unit-blueprint related to issues in unit blueprints (*_unit.bp) labels Feb 9, 2020
@speed2CZ speed2CZ added the area: sim Area that is affected by the Simulation of the Game label Feb 9, 2020
@shalkya
Copy link
Member

shalkya commented Feb 9, 2020

can't see the difference between the 2 last pic.
otherwise cool stuff, i will test that soon.

@speed2CZ
Copy link
Member Author

speed2CZ commented Feb 9, 2020

The last one is very small change, its the white foam that is right next to the edges of the ship. Mostly noticable in this area:
firefox_2020-02-09_15-24-23

Uveso
Uveso approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@Uveso Uveso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixes are working and showing the effects from the pictures above.

@PhilipJFryFAF
Copy link
Contributor

tested and works
as always good job on the fix!
also, the shield boat stuff really bothers me now - was that issue introduced when increasing the unit size?

@PhilipJFryFAF PhilipJFryFAF merged commit cc169aa into FAForever:deploy/fafdevelop Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uveso Uveso Uveso approved these changes

Assignees
No one assigned
Labels
area: sim Area that is affected by the Simulation of the Game area: ui Anything to do with the User Interface of the Game area: unit-blueprint related to issues in unit blueprints (*_unit.bp)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@speed2CZ @shalkya @PhilipJFryFAF @Uveso