Reduce GetBlueprint() calls in weapons #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some were pretty obvious, just save the first call in a local variable and reuse. Then saving some values directly in the weapon table and reusing them.
speed2CZ
requested review from
KionX,
aeoncleanse,
shalkya,
HUSSAR-mtrela,
Uveso and
Strogoo
KionX
approved these changes
Nov 8, 2020
There was a problem hiding this comment.
Line 446 in f5564ff
Can delete it as it is checked in OnCreate
HUSSAR-mtrela
requested changes
Nov 8, 2020
There was a problem hiding this comment.
@speed2CZ this is a good implement but there are a few small changes that should be done in this PR.
| self.bpRateOfFire = bp.RateOfFire | ||
| self.EnergyRequired = bp.EnergyRequired | ||
| self.EnergyDrainPerSecond = bp.EnergyDrainPerSecond | ||
| self.WeaponUnpacks = bp.WeaponUnpacks |
There was a problem hiding this comment.
setting these variables are not needed if you make this change in OnCreate function:
self.bp = self:GetBlueprint()
then rest of the code can access above variables and many more directly from blueprint table like this:
self.bp.RateOfFire -- instead of self.bpRateOfFire
self.bp.EnergyRequired -- instead of self.EnergyRequired
HUSSAR-mtrela
approved these changes
Nov 9, 2020
Already done in OnCreate
HUSSAR-mtrela
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some were pretty obvious, just save the first call in a local variable and reuse.
Then saving some values directly in the weapon table and reusing them.