Layer optimizations #3358
Closed
Layer optimizations #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time a unit changes layer the new layer is stored inside the unit. In my own investigations this appeared to be a reliable change to GetCurrentLayer as it always returned the right values. It prevents an engine call in some of the most called functions (such as OnMotionHorzEventChange) - which is a significant improvement in comparison to retrieving a table value.
Sheikah45
reviewed
Aug 17, 2021
| @@ -5,7 +5,7 @@ | |||
| --#** | |||
| --#** Summary : Seraphim Hydrocarbon Power Plant Script | |||
| --#** | |||
| --#** Copyright � 2007 Gas Powered Games, Inc. All rights reserved. | |||
| --#** Copyright � 2007 Gas Powered Games, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Ha seems like there might be an unintentional encoding change
KionX
reviewed
Aug 17, 2021
| @@ -130,7 +130,8 @@ end | |||
| function Unit:GetConsumptionPerSecondMass() | |||
| end | |||
|
|
|||
| --- Return the name of the layer the unit is currently in. | |||
| --- Return the name of the layer the unit is currently in. This value is cached inside | |||
| -- unit.Layer each time a layer changes (when OnLayerChanged is called). | |||
|
There is no inherited call OnLayerChange in defaultunits.lua 2145... |
|
I think you are referring to https://github.com/FAForever/fa/blob/deploy/fafdevelop/lua/defaultunits.lua#L2225 . You are right, missed that one. |
|
Closed in favor of #3366 - which is essentially the same but because of my git setup the previous one was on FAForever and this one is coming from a fork. Also easily fixes the encoding problem Sheikah pointed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caches the GetCurrentLayer() outcome each time when OnLayerChange() is called by the engine. In turn, we save on engine calls while at the same time not breaking compatibility with mods and / or unchanged code.