Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone issues #3457

Merged
merged 5 commits into from Sep 30, 2021
Merged

Drone issues #3457

merged 5 commits into from Sep 30, 2021

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Sep 29, 2021

Fixes a few drone issues:

  • Add INSIGNIFICANTUNIT category as that prevents all kinds of interaction.
  • Add UnitId to the drone as that is a value scripts expect to be cached.
  • Removes drones from UpdateAssistersConsumption function.

An example of interaction that is not desirable: being able to change the target the drone is 'building' as seen in this cast.

Has no impact on the performance of the drones.

With thanks to Softles and Archsimkat.

@Garanas Garanas linked an issue Sep 29, 2021 that may be closed by this pull request
@Garanas Garanas added this to the 3724 milestone Sep 29, 2021
@Garanas
Copy link
Member Author

Garanas commented Sep 30, 2021

Just tested it again and reviewed the code changes - all appears to be good. The issues described by Archsimkat & Softles appear to have been solved as I can no longer re-produce the issue of Softles AI.

@Garanas Garanas merged commit 3eac29b into FAForever:deploy/fafdevelop Sep 30, 2021
@Garanas Garanas deleted the drone-issues branch September 30, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnitId of Cybran drones are not set
1 participant