Feature/ally overflow #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent unknown mods from hooking into the lobby using brittle file concatenation, causing issues. Closes FAForever#336
Crotalus
force-pushed
the
feature/ally-overflow
branch
from
de1d25b
to
2ebc11e
Compare
|
👍 |
|
This feature needs some improvement before merge. The big one is that it displays an odd string sometimes. |
|
Is this not what Crotalus is adressing with "(Quality is now visible if actually set in the game)"? What I'd like to see is for all of it to be optional. |
|
Is already a option, no ? |
|
In that case: 👍 |
|
Yeah the ally overflow stuff is an option. Quality indicator should be own UI option I think, they don't have anything in common really except being in the same pull request |
Looks like someone screwed up a merge conflict somewhere and brought this now very-much-dead code back.
It was always false, and all it does when true is makes a fairly seriousm class of bug into a silent failure. Helpful!
Simplify handling of game options by: - Make the key used to store each game option in the profile be a predictable function of the key, not an arbitrary "pref" value that has to live in lobbyOptions. - Store option values in the profile instead of keys into the options array. - Eliminate the now-redundant LastScenario value.
... Which gets us back under the upvalue limit again.
Pull the slot creation into its own function to bring the upvalue count down, and to make things a bit clearer.
It's now possible to specify an acceptable *set* of options for game rankedness.
- Change Unit Cap default (for Ranked settings) - Default spawn setting to "fixed" Closes FAForever#374
This commit introduces a new class to represent map previews, with the capability to show resource points as well. This allows us to remove a lot of duplicated logic for handling the large map, as well as adding resource previewing to the map previews in the map select screen and main lobby essentially for free. To make the performance of the rendering of the resource icons acceptable, a mechanism for object-pooling sets of identical bitmaps is introduced (Avoiding the expensive operation of creating and destroying many Bitmaps whenever the map view tries to update, which would otherwise introduce considerable "jank" to the map selection screen). This also makes the in-lobby map preview square.
When doing a QuickDialog with no buttons, don't attempt to lay out the button. Fixes FAForever#458
All can now remove text pings (otherwise they would just move it offscreen anyway)
Remove duplicate code and make the attack decals function more generic to support all types. Instead of updating attack decals every frame, instead update main parts at command mode change.
Seems like the engine wants the unit to live at least 1 tick to be able to grab the pose in TryCopyPose(). Maybe it sometime garbage collects the unit before it actually can copy it. This is mitigated by waiting at least 1 tick before destroying the unit.
Show storage information in team * There's now storage information in score and economy overlays * Show in score if someone is ally / foe (red / green) * Refactored the code to use own economy sync function * New UI-option: Team economy - Option is off by default
Crotalus
force-pushed
the
feature/ally-overflow
branch
from
4b408e4
to
7b6bdb6
Compare
ChrisKitching
force-pushed
the
develop
branch
2 times, most recently
from
03c0faa
to
1fae893
Compare
|
Needs rebasing, let's consider getting this optionally into 3641? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show team overflow in economy / score
(Quality is now only visible if actually set in the game)