Annotate campaign related functions pt. 2 #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed2CZ
reviewed
Jun 26, 2022
speed2CZ
reviewed
Jun 26, 2022
lua/SimObjectives.lua
Outdated
| --- | Objective data | Description | | ||
| --- | --------------------- | ------------- | | ||
| --- | Units | Table of units to kill | ||
| --- | NumRequired | Number of units required for the objective to pass |
There was a problem hiding this comment.
Kill objective doesnt support NumRequired
speed2CZ
reviewed
Jun 26, 2022
| --- | --------------------- | ------------- | | ||
| --- | Units | Table of units to kill | ||
| --- | NumRequired | Number of units required for the objective to pass | ||
| --- | MarkUnits | Flag to to mark the units with an objective arrow the units are marked with an objective arrow |
There was a problem hiding this comment.
You could add to the description that the default value is true, so it's basically used only to not mark the units if you set it to false.
speed2CZ
reviewed
Jun 26, 2022
| ---@param Complete ObjectiveStatus # Completion status, usually this is 'incomplete' unless the player already completed it by chance | ||
| ---@param Title string # Title of the objective, supports strings with LOC | ||
| ---@param Description string # Description of the objective, supports strings with LOC | ||
| ---@param Target table # Objective data, see the description |
|
I'll process the feedback in a future pull request, I need something to trigger the hook 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.