Remove NaturalProducer from C-D2 "Rover"
#4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-D2 "Rover" produces no resources, so should not have this stat.
Garanas
approved these changes
Dec 13, 2022
|
I'm not sure if this value does anything. But it is technically correct to remove it from this unit. |
|
@Garanas Since I've been finding a few of these weird quirks in the blueprints, would I be better off just dropping a pull request with a bunch of changes or should I make issues for each change too? Not sure about git etiquette. Also not sure how many more I'll find, but thought I'd ask. |
|
If these are similar blueprint changes like these then it is fine to make a pull request. We prefer smaller pull requests. We use issues primarily to discuss larger changes and feature requests. |
Garanas
pushed a commit
that referenced
this pull request
Jan 28, 2023
C-D2 "Rover" produces no resources, so should not have this stat.
Garanas
added
type: bug
area: sim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C-D2 "Rover"produces no resources, so should not have this attribute. The only units that should have it are the ACUs and sACUs.Closes #4498