Allow negative aix cheat multipliers #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of changes: This PR changes the range of selectable aix cheat values to include some negative multipliers. 0.5->0.9. This also required a change to the default selection value as 5 entries are being added to the start of the list. The same default of 1.5 is retained. This will allow players to choose a harder cheating aix in terms of resources, but lowering their build speed to allow more time for the player to react. Alternatively a player could restrict an aix's resources but retain its build speed.
|
Looking good! I'll give it a closer look this weekend |
Garanas
added
area: lobby
Garanas
approved these changes
Dec 23, 2022
|
@ANIALLATOR114 one minor note: you can use 'closing keywords' to automatically close the issue you're trying to solve when the pull request is merged. As an example: closes #4324 |
Garanas
pushed a commit
that referenced
this pull request
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I saw this mentioned here but couldn't find an open issue/pr for the change. #4324 (comment)
This PR changes the range of selectable aix cheat values to include negative multipliers. 0.5->0.9.
This also required a change to the default selection value as 5 entries are being added to the start of the list. The same default of 1.5 is retained.
This will allow players to choose a harder cheating aix in terms of resources, but lowering their build speed to allow more time for the player to react. Alternatively a player could restrict an aix's resources but retain its build speed.
Testing:
Open a lobby and observe the default value has retained at 1.5 and now values less than 1.0 are selectable.
Open a skirmish match with aix and observe their resource production and build speed match the value set in the lobby.
I set 0.5 for both in this example.
buildspeedhalf.mp4
ps - This is my first contribution to FAF so please let me know if I'm missing anything here!