SCU rebalance #4621
SCU rebalance #4621
Conversation
Nerfs the base SCU and adjusts the upgrades to compensate for the nerf.
ners the base aeon SCU and redistributes the nerfs over the different upgrades.
ners the base sera SCU and redistributes the nerfs over the different upgrades.
nerfs the base cybran SCU and redistributes the nerfs over the different upgrades.
|
What are the ink files 🤔 ? |
|
Please fix some of the formatting issues and the ink files. Also, shouldn't the Cybran have 10k hp if we are going with the same hp as the ACU theme? |
|
Please resolve the conflict so that I can merge the PR |
|
Won't this affect how much HP these units gain when they vet? These changes will affect the 3 factions with shieldable SACUs more than the last faction. This won't really affect Cybran SACUs as they get their base HP back with the upgrade. ~ Stryker |
|
It will have slight effects on the units but it really doesn't matter. The difference will be negligible. |
| @@ -494,7 +494,7 @@ UnitBlueprint { | |||
| Icon = 'ss', | |||
| Name = '<LOC enhancements_0031>Reacton Refractor', | |||
| NewDamageRadiusMod = 3.5, | |||
|
|
|||
| NewDamageMod = 200, | |||
There was a problem hiding this comment.
You have to add the NewDamageMod to both the Enhancement and it's removal since in the script you refer to the instance of the Enhancement. The script of the Aeon SCU needs to be changed as well.
wep:AddDamageMod(-self:GetBlueprint().Enhancements['RightReactonCannon'].NewDamageMod)
This line makes no sense AFAIK, it should be
wep:AddDamageMod(-bp.NewDamageMod)
There was a problem hiding this comment.
Actually you could change this:
wep:AddDamageMod(-self:GetBlueprint().Enhancements['RightReactonCannon'].NewDamageMod)
to:
wep:AddDamageMod(-self:GetBlueprint().Enhancements['StabilitySuppressant'].NewDamageMod)
| elseif enh =='AdvancedCoolingUpgradeRemove' then | ||
| local wep = self:GetWeaponByLabel('RightHeavyPlasmaCannon') | ||
| wep:ChangeRateOfFire(self:GetBlueprint().Weapon[1].RateOfFire or 1) | ||
| wep:AddDamageMod(-bp.UpgradeDamageMod) |
There was a problem hiding this comment.
wep:AddDamageMod(-self:GetBlueprint().Enhancements['AdvancedCoolingUpgrade'].UpgradeDamageMod)
| @@ -399,6 +399,7 @@ UnitBlueprint { | |||
| 'Back_Upgrade', | |||
| }, | |||
| Slot = 'Back', | |||
| UpgradeDamageMod = 300, | |||
There was a problem hiding this comment.
This should be NewDamageMod
| @@ -156,6 +157,7 @@ XSL0301 = Class(CommandUnit) { | |||
| self:SetIntelRadius('Vision', bpIntel.VisionRadius or 26) | |||
| self:SetIntelRadius('Omni', bpIntel.OmniRadius or 16) | |||
| local wep = self:GetWeaponByLabel('LightChronatronCannon') | |||
| wep:AddDamageMod(-bp.NewDamageMod or 0) | |||
There was a problem hiding this comment.
wep:AddDamageMod(-wep:AddDamageMod(-self:GetBlueprint().Enhancements['EnhancedSensors'].NewDamageMod))
|
@Garanas |
|
@TurinturambarFAF Can you allow me to push to your Repo so that I can update this branch with the changes fixing all those things I mentioned in the review? |
I'm not too familiar with how enhancements work, but it seems to me it is best to do the same thing that the gun upgrade of ACUs do in terms of coding style. |
Nerfs the raw SCU HP and dps to the level of a vanilla ACU and also nerfs the raw SCU bp from 56 to 40 and compensates these changes by buffs of the respective upgrades.
See: #4642