Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to abort the navigation of engineers #5655

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Nov 9, 2023

Originates from a discussion with @clyfordv and @gordenwunderlich on Discord. Inspired by #5628 and #5558. There are interesting side effects to aborting navigation. One of them is that other commands (assist, build, reclaim) use the 'done navigating' as a callback to try and trigger the actual command

abort-assist.mp4
abort-build.mp4

If used properly the engineer can then immediately apply the order
@Garanas Garanas added this to the Development iteration V milestone Nov 9, 2023
@Garanas
Copy link
Member Author

Garanas commented Nov 9, 2023

And why it only applies to engineers and not (among others) transports:

abort-unload-hellooo.mp4

@Garanas Garanas marked this pull request as ready for review November 11, 2023 17:30
@Garanas Garanas added feature: interrupt pathfinding related to the ability to interrupt the path finding feature: hotkeys related to miscellaneous hotkeys labels Nov 11, 2023
@Garanas Garanas merged commit ad3f306 into deploy/fafdevelop Nov 12, 2023
2 checks passed
@Garanas Garanas deleted the feature/abort-navigation-for-engineers branch November 12, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: hotkeys related to miscellaneous hotkeys feature: interrupt pathfinding related to the ability to interrupt the path finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant