Improve performance of navigational functions #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garanas
commented
Jan 27, 2024
| local current = 1 | ||
| local stack = { sectionOrigin } |
There was a problem hiding this comment.
Instead of creating new tables for each function call we use a cache that is provided to us by the function parameters.
This is an internal function (note the 'local' keyword). Therefore we have full control over the cache.
Garanas
commented
Jan 27, 2024
| -- if neighbor exceeds the distance then we pick the neighbor | ||
| local dx = ox - neighbor.Center[1] | ||
| local dz = oz - neighbor.Center[3] | ||
| if MathSqrt(dx * dx + dz * dz) < distance then |
There was a problem hiding this comment.
We can skip the square root by squaring the distance.
Garanas
commented
Jan 27, 2024
| local msg = count --[[@as string]] | ||
| return nil, msg | ||
| end | ||
|
|
||
| -- only keep those at the edge |
There was a problem hiding this comment.
Add the possibility for the user to provide a cache to prevent table allocations.
Garanas
commented
Jan 27, 2024
|
|
||
| ---@type Vector[] | ||
| local points = { } |
There was a problem hiding this comment.
This should be cacheable via a parameter too, but we'll keep that for the next pull request 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the table trashing that occurs when retrieving nearby sections. The improvements applies to:
GetPositionsInRadiusDirectionsFromDirectionsFromWithThreatThreshold