Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and rework the categories of UEF naval units #5929

Merged
merged 5 commits into from Mar 1, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Feb 22, 2024

Related to #5919

Introduces the WEAK... categories to various units. Also removes the NUKE category from the strategic bomber as it is... not a strategic unit.

What I found interesting is that the ANTINAVY category actually means anti submarine. Weapons that are anti navy are torpedo-like weapons.

@Garanas Garanas added the feature: target priorities related to the target priorities of weapons label Feb 22, 2024
@Garanas Garanas changed the title Rework/categories/uef/naval valuate and rework the categories of UEF naval units Feb 22, 2024
@Garanas Garanas changed the title valuate and rework the categories of UEF naval units Evaluate and rework the categories of UEF naval units Feb 22, 2024
@Garanas
Copy link
Member Author

Garanas commented Feb 22, 2024

@relent0r / @maudlin27 please evaluate these category changes to make sure they do not mess with your AI 😃 !

Especially the removal of ANTINAVY from the Battlecruiser and the Destroyer. They still have the overlay and the WEAKANTINAVY categories, but they do not deserve the ANTINAVY category.

@relent0r
Copy link
Contributor

relent0r commented Feb 22, 2024

This one I don't love, its going to cause problems when trying to analyze if destroyers can deal with submarines or attack an underwater unit.

I'd also debate if they are considered weak antinavy, but I'm no expert there.

@Garanas
Copy link
Member Author

Garanas commented Feb 22, 2024

The destroyers of the UEF are definitely not made to fight submarines. It's intentionally weak because of the Torpedo Boat.

Do you have snippets of code where you analyze what a unit can (not) target?

@relent0r
Copy link
Contributor

An example of the use case would be something like this.

PlatoonTemplate {
Name = 'RNGAI Sea Hunt',
Plan = 'StateMachineAIRNG',
GlobalSquads = {
{ categories.MOBILE * categories.NAVAL * categories.ANTINAVY, 1, 10, 'Attack', 'GrowthFormation' }
},
}

This is used for taking out under water mexes and dealing with submarines. With this change the AI would never form this platoon if only destroyers were available, even though a destroyer can tank enough damage to take out multiple submarines attacking its units without much trouble.
But thats more of a balance debate than a functionality one. You could apply the same logic to frigates since they have weak aa, but then if you've got a group of frigates and someones using t1 bombers to destroy them your not going to pack up and go home as they can tank the damage and dish out enough to kill the bomber/s.

So for this PR I would need to add another category to a platoon former like this is all. Not the end of the world and not a major inconvenience.

@Garanas
Copy link
Member Author

Garanas commented Mar 1, 2024

@relent0r I've re-introduced the ANTINAVY categories. We can look into that separately in the future if the need arises. Thank you for your time on the responses

@Garanas Garanas merged commit bc43a00 into deploy/fafdevelop Mar 1, 2024
3 checks passed
@Garanas Garanas deleted the rework/categories/uef/naval branch March 1, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: target priorities related to the target priorities of weapons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants